Hello!
I'm pretty new to PD and have been building my first polyphonic synth for the last couple of days.
I use [poly] with 10 voices and send note number and velocity to the oscillators and only velocity to the envelope.

Before last night I could press and hold a key on my Beatstep Pro and the note would keep playing until I let go, at which point the release kicked in.
Same if i pressed multiple keys on the BSP.
For some reason this changed last night without me touching the ADSR.
I can see that velocity 0 reaches the ADSR and on the right channel, but if I don't release the key before the sustain is finished the note will just cut off. This is probably because it needs velocity 0 to trigger the release, but it doesn't explain why I can't hold the keys anymore.
To make even more weird, sometimes when I hold a key it works...

Any idea why this happens?
If you want, I can post the whole patch but the problem seem to be in the ADSR.

Also, I'm running vanilla.

Peace!

@jocke Hard to tell. You should definitely put [trigger] 's where you have 2 cords leaving an outlet.
i.e
[inlet]
|
[t f f]

..... so as to be certain that you have the correct (right first left last] order of operations.
When you release the note you are sending 3 messages into [vline~].... 2 from the left and one from the right.
Put a [print] to see them and in which order they arrive [print x] [print y]
David.

@whale-av Thanks a lot!
By printing the messages I could see that the [vline~] received the same message twice. Once when I pressed the key, and then again when I released it. No idea why it worked before, I'm guessing my BSP is a little buggy.
Anyways, solved it with a [spigot] and now it works like a charm.
Thanks again!

In my class demos about envelopes, I did it like this:

(velocity source)
|
[moses 1]
|       |
|       (envelope attack/decay segment messages)
|
(release segment message)

And both of the messages to vline~.

Instead of sending the velocity down both branches and stopping the flow for one of them, this way splits the velocity into on and off paths directly.

hjh

@ddw_music That is a cleaner way of doing it. But I think it will give me the same problems I had before the [spigot] since the BSP seem to send the message twice which would mean that both the note_on and the note_off messages would reach the [vline~] at the same time. But maybe I'm not understanding [moses] correctly so I will try it tonight and get back!

@jocke said:

@ddw_music That is a cleaner way of doing it. But I think it will give me the same problems I had before the [spigot] since the BSP seem to send the message twice which would mean that both the note_on and the note_off messages would reach the [vline~] at the same time.

It won't. [moses] means: if the incoming value is less than the set value, send the float out the left outlet. If it's >= the set value, send it out the right outlet.

There is no way that a single real number can be both < x and >= x -- so the float can go out only one of the outlets. It's impossible to have one incoming message go out to both outlets at once.

hjh